RFR: 8330198: Add some class loading related perf counters to measure VM startup [v3]
Calvin Cheung
ccheung at openjdk.org
Wed Jun 5 22:24:48 UTC 2024
On Tue, 4 Jun 2024 05:13:58 GMT, David Holmes <dholmes at openjdk.org> wrote:
>>> The -Xlog:init (perhaps with a better name/tag!)
>>
>> I'm all for a better naming scheme. Any suggestions?
>
>> -Xlog:init means "I want to see logs related to initialization", so it should enable all the counters for printing the related logs.
>
> I don't agree. Initialization logging could encompass many different things, some of which are individually controllable via different flags. Simply turning on init logging should not turn on all such flags. If you want that level of coupling then perhaps use init_counters (or something like that) to make it clear this is not a general log tag intended for any initialization code to use, but something you have chosen to tie to specific functionality.
>
>> We may add several groups of counters in the future. We don't want to force the user to enumerate all these counters
>
> It is not clear to me how you envisage that working. You want individual group switches plus a global one?
@dholmes-ora, @iklam Could you review my latest commit?
Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18790#discussion_r1628504608
More information about the hotspot-dev
mailing list