RFR: 8333382: [s390x] Enhance popcnt Instruction to use Z15 facilities

Lutz Schmidt lucy at openjdk.org
Fri Jun 7 14:07:15 UTC 2024


On Fri, 7 Jun 2024 13:45:20 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/s390/s390.ad line 10757:
>> 
>>> 10755: 
>>> 10756:     // Prefer compile-time assertion over run-time SIGILL.
>>> 10757:     assert(VM_Version::has_PopCount(), "bad predicate for popCountL");
>> 
>> Duplicate check! But you may want to check for different registers (if you don't trust the effect().
>
> I can add assert. But there is already one assert to check this in `macroAssembler_s390.cpp` file. Do you want one more here as well ?

Ahhh sorry. Did not cross-check. It is OK then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19509#discussion_r1631273302


More information about the hotspot-dev mailing list