RFR: 8333775: Small improvement to outputStream auto-indentation mode

Johan Sjölen jsjolen at openjdk.org
Mon Jun 10 09:37:11 UTC 2024


On Fri, 7 Jun 2024 08:40:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Almost trivial enhancement.
> 
> [JDK-8333211](https://bugs.openjdk.org/browse/JDK-8333211) added automatic indentation. Some changes to complement that:
> 
> - let outputStream::set_autoindent() return the old value for later restoration
> - add an RAII object to enable autoindent and restore the old state when leaving.

Hi Thomas,

LGTM but can you make the `StreamAutoIndentor` `NONCOPYABLE' also? Copying it makes no sense. Trivial.

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19592#pullrequestreview-2107269818


More information about the hotspot-dev mailing list