RFR: 8331352: error: template-id not allowed for constructor/destructor in C++20

[Kim Barrett]

On Tue, 11 Jun 2024 00:17:29 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Ironic that I'm now facing the same issue on Windows:
> 
> ```
> C:/users/vertig0/downloads/eclipse-committers-2023-12-r-win32-x86_64/workspace/jdk/src/hotspot/os/windows/symbolengine.cpp:93:67: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
>    93 |   SimpleBufferWithFallback<T, MINIMAL_CAPACITY, OPTIMAL_CAPACITY> ()
>       |                                                                   ^
> C:/users/vertig0/downloads/eclipse-committers-2023-12-r-win32-x86_64/workspace/jdk/src/hotspot/os/windows/symbolengine.cpp:93:67: note: remove the '< >'
> cc1plus.exe: all warnings being treated as errors
> ```
> 
> I was going to suppress the warning in the Makefiles, but then remembered about this Pull Request. Should I send a changeset to fix this upstream or just suppress the warning in my Windows/gcc Port?

I'm okay with having this fixed in openjdk.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19009#issuecomment-2159775466