RFR: 8333382: [s390x] Enhance popcnt Instruction to use Z15 facilities [v7]

Amit Kumar amitkumar at openjdk.org
Tue Jun 11 10:06:17 UTC 2024


On Tue, 11 Jun 2024 09:15:41 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   corrects the regsiter for z_popcnt in pop_count_long_post_z15 method
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 5871:
> 
>> 5869: }
>> 5870: 
>> 5871: void MacroAssembler::pop_count_long_post_z15(Register r_dst, Register r_src) {
> 
> I know the name was my suggestion, but perhaps `pop_count_long_ext3` and `pop_count_long_pre_ext3` would be better.

what about using with and without like this “pop_count_with_ext3” ? 

But I still think that current naming is also not that bad….

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19509#discussion_r1634575049


More information about the hotspot-dev mailing list