RFR: 8333887: ubsan: unsafe.cpp:247:13: runtime error: store to null pointer of type 'volatile int'

[Lutz Schmidt]

On Wed, 12 Jun 2024 07:02:17 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> src/hotspot/share/prims/unsafe.cpp line 249:
>> 
>>> 247: #if defined(__clang__) || defined(__GNUC__)
>>> 248: __attribute__((no_sanitize("undefined")))
>>> 249: #endif
>> 
>> Can we hide this in a macro like `SUPPRESS_UBSAN_WARNING`? If it turns out we need to do this in a few places then it will look nicer.
>
> Sounds like a good idea.  See also the discussion about `ATTRIBUTE_NO_UBSAN`  here  https://github.com/openjdk/jdk/pull/19597

I like the idea of an encapsulating macro as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19630#discussion_r1636199928