RFR: 8333769: Pretouching tests dont test pretouching
Sonia Zaldana Calles
szaldana at openjdk.org
Thu Jun 13 13:45:26 UTC 2024
Hi all,
This PR addresses [8333769](https://bugs.openjdk.org/browse/JDK-8333769).
We already have a test for parallel GC that makes sure pretouching behaviour is correct ([test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java)).
Unfortunately this test is limited to linux because of the scanning of `/proc/pid/status`. With this patch I propose two changes:
- Adding a function to the os namespace `os::rss` and exposing this API via WhiteBox. This in turn allows us to generalize the above test to be used across all platforms.
- Running the modified test with all collectors.
Additionally, I considered removing other pre-existing pretouch tests (for example, this [z test](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/gc/z/TestAlwaysPreTouch.java)), as this new test is a bit more thorough. However, I noticed that some of these tests run alongside other configurables such as varying numbers of parallel GC threads, varying heap sizes, etc. Therefore, there might not be any harm in running these tests as well.
Looking forward to your comments,
Sonia
-------------
Commit messages:
- 8333769: Pretouching tests dont test pretouching
Changes: https://git.openjdk.org/jdk/pull/19699/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19699&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8333769
Stats: 240 lines in 9 files changed: 160 ins; 80 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/19699.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19699/head:pull/19699
PR: https://git.openjdk.org/jdk/pull/19699
More information about the hotspot-dev
mailing list