RFR: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV

[Hamlin Li]

On Thu, 13 Jun 2024 03:24:15 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi, test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java fails without RVV after [JDK-8332153](https://bugs.openjdk.org/browse/JDK-8332153) in fastdebug mode.  see jbs issue for exception information.
> 
> As discussed on jbs, we prefixed the single letter cpu features with rv so that there would be no problem. And to synchronize the test cases.
> 
> After this patch, we can get cpu feature string like this:
> 
> ----------System.out:(4/168)----------
> WB.getCPUFeatures(): "rv64 rvi rvm rva rvf rvd rvc rvv"
> CPUInfo.getAdditionalCPUInfo(): ""
> CPUInfo.getFeatures(): [rv64, rvi, rvm, rva, rvf, rvd, rvc, rvv]
> TEST PASSED
> 
> 
> ### Testing
> - [x] All Tests related to all changes in this patch on Banana Pi BPI-F3 board (with RVV1.0) (fastdebug)
> - [x] All Tests related to all changes in this patch on SOPHON SG2042 (fastdebug)
> - [ ] Run tier1-3 tests on SOPHON SG2042 (fastdebug)

Thanks for fixing the issue.
Some comments.

src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 137:

> 135:           // like rvc, rvv, etc so that it will be easier to specify
> 136:           // target feature string in tests.
> 137:           strcat(buf, " rv");

Could there be any naming conflicting in the future? ie. there will be extension named rvd, etc.
I'm not sure if the current riscv extension naming convention will avoid this situation, if answer is postive, then it looks good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19686#pullrequestreview-2118567094
PR Review Comment: https://git.openjdk.org/jdk/pull/19686#discussion_r1639938403