RFR: 8332587: RISC-V: secondary_super_cache does not scale well [v6]

Gui Cao gcao at openjdk.org
Sat Jun 15 07:12:13 UTC 2024


On Fri, 14 Jun 2024 11:19:57 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8332587
>>  - Update ins_cost for PartialSubtypeCheck
>>  - Code Format
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8332587
>>  - Polish Code Comment
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8332587
>>  - Fix Code format
>>  - Fix for Hamlin comment
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8332587
>>  - Fix client VM build
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/b0b13fc2...142d7677
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5613:
> 
>> 5611:     }
>> 5612: 
>> 5613: #ifdef COMPILER2
> 
> Maybe put other "secondary super table" related code also inside COMPILER2 macro?

Hi, I I've put "secondary super table" related generate code inside COMPILER2 macro. The related code in macroAssembler, which I guess the C1 optimization[1] may also use, is currently consistent with arm64,x86, etc., and has not been put into COMPILER2 macro.

[1] https://bugs.openjdk.org/browse/JDK-8331658

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19320#discussion_r1640837578


More information about the hotspot-dev mailing list