RFR: 8332603: [PPC64] Improve itable_stub [v2]

[Varada M]

On Mon, 17 Jun 2024 05:02:18 GMT, Varada M <varadam at openjdk.org> wrote:

> Testing is fine with release VM, I see one failure `test/hotspot/jtreg/gtest/GTestWrapper.java` with fastdebug on aix-ppc.
> 
> Here is the benchmark results.
> 
> ```
> Before patch: 
> 
> Benchmark                        Mode  Cnt   Score   Error  Units
> InterfaceCalls.test1stInt2Types  avgt   12  18.084 ? 0.160  ns/op
> InterfaceCalls.test1stInt3Types  avgt   12  26.789 ? 0.282  ns/op
> InterfaceCalls.test1stInt5Types  avgt   12  26.926 ? 0.438  ns/op
> InterfaceCalls.test2ndInt2Types  avgt   12  18.500 ? 0.215  ns/op
> InterfaceCalls.test2ndInt3Types  avgt   12  30.996 ? 0.489  ns/op
> InterfaceCalls.test2ndInt5Types  avgt   12  28.395 ? 0.215  ns/op
> InterfaceCalls.testIfaceCall     avgt   12  26.749 ? 0.238  ns/op
> InterfaceCalls.testIfaceExtCall  avgt   12  28.189 ? 0.395  ns/op
> InterfaceCalls.testMonomorphic   avgt   12  15.251 ? 0.126  ns/op
> Finished running test 'micro:vm.compiler.InterfaceCalls'
> Test report is stored in build/aix-ppc64-server-release/test-results/micro_vm_compiler_InterfaceCalls
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR   
>    micro:vm.compiler.InterfaceCalls                      1     1     0     0   
> ==============================
> TEST SUCCESS
> 
> Finished building target 'test' in configuration 'aix-ppc64-server-release'
> 
> 
> After patch :
> 
> Benchmark                        Mode  Cnt   Score   Error  Units
> InterfaceCalls.test1stInt2Types  avgt   12  18.078 ? 0.133  ns/op
> InterfaceCalls.test1stInt3Types  avgt   12  26.816 ? 0.276  ns/op
> InterfaceCalls.test1stInt5Types  avgt   12  26.918 ? 0.233  ns/op
> InterfaceCalls.test2ndInt2Types  avgt   12  18.674 ? 0.204  ns/op
> InterfaceCalls.test2ndInt3Types  avgt   12  30.360 ? 0.251  ns/op
> InterfaceCalls.test2ndInt5Types  avgt   12  28.356 ? 0.394  ns/op
> InterfaceCalls.testIfaceCall     avgt   12  26.676 ? 0.188  ns/op
> InterfaceCalls.testIfaceExtCall  avgt   12  27.613 ? 0.258  ns/op
> InterfaceCalls.testMonomorphic   avgt   12  15.175 ? 0.090  ns/op
> Finished running test 'micro:vm.compiler.InterfaceCalls'
> Test report is stored in build/aix-ppc64-server-release/test-results/micro_vm_compiler_InterfaceCalls
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR   
>    micro:vm.compiler.InterfaceCalls                      1     1     0     0   
> ==============================
> TEST SUCCESS
> ```

GTestWrapper Failure :

[----------] 2 tests from code
[ RUN      ] code.vtableStubs_vm
[       OK ] code.vtableStubs_vm (0 ms)
[ RUN      ] code.itableStubs_vm
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/home/hotspot/openjdk/jdk-varada/src/hotspot/cpu/ppc/assembler_ppc.hpp:1028), pid=16777526, tid=258
#  assert(nbits == 32 || (-(1 << (nbits-1)) <= x && x < (1 << (nbits-1)))) failed: value out of range
#
# JRE version: OpenJDK Runtime Environment (24.0) (fastdebug build 24-internal-adhoc.hotspot.jdk-varada)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 24-internal-adhoc.hotspot.jdk-varada, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, aix-ppc64)
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/hotspot/openjdk/jdk-varada/build/aix-ppc64-server-fastdebug/test-support/jtreg_test_hotspot_jtreg_gtest_GTestWrapper_java/scratch/0/hs_err_pid16777526.log
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19733#issuecomment-2172479057