RFR: 8332689: RISC-V: Use load instead of trampolines [v11]

Robbin Ehn rehn at openjdk.org
Mon Jun 17 07:55:16 UTC 2024


On Thu, 13 Jun 2024 19:17:13 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Remove tmp file
>>  - Prepare for dynamic NativeCall size
>>  - Only allow one calling convetion, i.e. fixed sized
>>  - Merge branch 'master' into 8332689
>>  - Review comments
>>  - Move shart/far code to cpp
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/5d2a19de...bb7249b8
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 382:
> 
>> 380: }
>> 381: 
>> 382: address NativeFarCall::reloc_destination(address orig_address) {
> 
> argument `orig_address` is not used

All these methods have the same signature, i.e.:
`address reloc_destination(address orig_address);`
Some may use the argument some may not.

> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 430:
> 
>> 428: }
>> 429: 
>> 430: bool NativeFarCall::reloc_set_destination(address dest) {
> 
> argument `dest` is not used.

Same here, all these methods have the same signature.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642351788
PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642352441


More information about the hotspot-dev mailing list