RFR: 8332603: [PPC64] Improve itable_stub [v2]

Amit Kumar amitkumar at openjdk.org
Mon Jun 17 16:11:26 UTC 2024


On Mon, 17 Jun 2024 14:22:22 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   consistency
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 1976:
> 
>> 1974:   bne(CCR0, L_loop_search_resolved);
>> 1975: 
>> 1976:   mr_if_needed(holder_offset, scan_temp);
> 
> I prefer using `mr` without "_if_needed" after you asserted that the registers are different.

Yeah, makes sense; I have fixed it, please see the latest commit;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19733#discussion_r1643063128


More information about the hotspot-dev mailing list