RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v2]
Volodymyr Paprotski
duke at openjdk.org
Mon Jun 17 16:38:55 UTC 2024
On Fri, 14 Jun 2024 23:39:54 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve non-intrinsic p256 performance
>
> src/hotspot/share/opto/runtime.cpp line 1417:
>
>> 1415: // result type needed
>> 1416: fields = TypeTuple::fields(1);
>> 1417: fields[TypeFunc::Parms + 0] = NULL;
>
> A minor nit: here NULL could be nullptr instead.
done, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19728#discussion_r1643093891
More information about the hotspot-dev
mailing list