Integrated: 8332105: Exploded JDK does not include CDS

Thomas Stuefe stuefe at openjdk.org
Mon Jun 17 17:30:26 UTC 2024


On Sat, 11 May 2024 06:13:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> An exploded JDK cannot be used with either -Xshare:on or -Xshare:auto. That causes tests like runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java to fail when running on an exploded JDK.
> 
> Since an exploded JDK cannot use CDS, we should - for tests - treat it as if CDS had not been included.
> 
> 
> ----
> 
> Note that I was torn between two ways to fix this:
> 
> - either this fix, which is rather simple and automatically updates the "vm.cds" `@requires` property
> - or to expose "exploded-ness" as a boolean property via `WhiteBox` and `VMProps`(`jdk.exploded`). See this draft PR: https://github.com/openjdk/jdk/pull/19178 . 
> 
> The latter is cleaner and clearer, conveying the message of exploded-ness without muddling it with the CDS aspect. But OTOH the complexity may not be required. 
> 
> I can go either way, though I have a slight preference for this PR, which is why I posted it.

This pull request has now been integrated.

Changeset: 801bf15f
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/801bf15f02ca47c3547eb677079d7d2f3af1de8c
Stats:     6 lines in 2 files changed: 5 ins; 0 del; 1 mod

8332105: Exploded JDK does not include CDS

Reviewed-by: dholmes, iklam

-------------

PR: https://git.openjdk.org/jdk/pull/19188


More information about the hotspot-dev mailing list