RFR: 8333658: NMT: Use an allocator with 4-byte pointers to save memory in NativeCallStackStorage [v21]

[Johan Sjölen]

On Tue, 18 Jun 2024 06:26:25 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix tests
>
> src/hotspot/share/nmt/indexedFreeListAllocator.hpp line 82:
> 
>> 80:   }
>> 81: 
>> 82:   void free(I i) {
> 
> `free_element` ? Or `return_element`? I dislike `free` as a name because of the conflict with free. For symmetry, then we need `allocate_element`.

Just `deallocate`?

> src/hotspot/share/nmt/indexedFreeListAllocator.hpp line 97:
> 
>> 95: 
>> 96:   const E& at(I i) const {
>> 97:     assert(i != nil, "null pointer dereference");
> 
> Not needed?

You're probably right, I'm not sure what a `const IFLA` would be.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18979#discussion_r1647202494
PR Review Comment: https://git.openjdk.org/jdk/pull/18979#discussion_r1647201951