RFR: 8322475: Extend printing for System.map [v5]

[Thomas Stuefe]

On Wed, 19 Jun 2024 17:02:53 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
>> 
>>  - copyrights
>>  - Merge branch 'master' into System.maps-more-info
>>  - fix merge issue
>>  - Merge branch 'master' into System.maps-more-info
>>  - fix whitespace issue
>>  - wip
>>  - exhuming
>>  - Merge branch 'master' into System.maps-more-info
>>  - Merge
>>  - remove codecache name printing
>>  - ... and 10 more: https://git.openjdk.org/jdk/compare/91bd85d6...231a8a91
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 41:
> 
>> 39:   size_t _vsize;        // combined virtual size
>> 40:   size_t _rss;          // combined resident set size
>> 41:   size_t _committed;    // combined committed space
> 
> What's the difference between a "space" and a "size"?

None, will fix.

> src/hotspot/os/linux/memMapPrinter_linux.cpp line 83:
> 
>> 81:     outputStream* st = _session.out();
>> 82: #define INDENT_BY(n)          \
>> 83:   if (st->fill_to(n) == 0) {  \
> 
> `fill_to` returns `void`, am I missing something?

It was changed in this PR to return the number of spaces actually printed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17158#discussion_r1647249197
PR Review Comment: https://git.openjdk.org/jdk/pull/17158#discussion_r1647251870