RFR: 8332689: RISC-V: Use load instead of trampolines [v12]

[Fei Yang]

On Thu, 20 Jun 2024 11:17:19 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/codeBuffer_riscv.cpp line 74:
>> 
>>> 72: 
>>> 73:   assert(requests->number_of_entries() >= 1, "at least one");
>>> 74:   const int total_requested_size = MacroAssembler::max_patchable_far_call_stub_size() * requests->number_of_entries();
>> 
>> I see mixed uses of bot `MacroAssembler::max_patchable_far_call_stub_size()` and `MacroAssembler::NativeShortCall::trampoline_size` in this function. As this is only used under `UseTrampolines`, seems more reasonable to use `MacroAssembler::NativeShortCall::trampoline_size`.
>
> As you see in diff the mixing is pre-exsisting, I only changed names.
> 
> Fixed.

Ah, I see. I think you are right in using `MacroAssembler::max_patchable_far_call_stub_size()` at places where we call `MacroAssembler::max_trampoline_stub_size()` previously. Could you please revert this part? I think I miss-read the code before. Sorry.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1648369390