RFR: 8331126: [s390x] secondary_super_cache does not scale well [v4]
Amit Kumar
amitkumar at openjdk.org
Tue Jun 25 03:29:12 UTC 2024
On Mon, 24 Jun 2024 18:39:02 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Amit Kumar has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update src/hotspot/cpu/s390/macroAssembler_s390.cpp
>> - rename: r_scratch to r_result in repne_scan method
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3173:
>
>> 3171: z_cg(r_value, Address(r_addr));
>> 3172: z_bre(L_exit); // branch on success
>> 3173: add2reg(r_addr, wordSize);
>
> Can add2reg change CC? I'd probably rather use z_la for the addition without changing CC.
I just noticed that `PreferLAoverADD` is by default set to false. I'm looking for a reason for that, maybe we can set it to true. Otherwise I'll update it to z_la.
CC: @RealLucy
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19544#discussion_r1651937491
More information about the hotspot-dev
mailing list