RFR: 8333994: NMT: call stacks should show source information [v5]

Thomas Stuefe stuefe at openjdk.org
Tue Jun 25 05:13:12 UTC 2024


On Sun, 23 Jun 2024 08:55:22 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanups
>
> src/hotspot/share/nmt/nativeCallStackPrinter.cpp line 40:
> 
>> 38:   for (int i = 0; i < NMT_TrackingStackDepth; i++) {
>> 39:     const address pc = stack->get_frame(i);
>> 40:     if (pc != nullptr) {
> 
> Style suggestion: Invert condition and `continue` instead, to reduce indentation of remaining code.

Just occurred to me that null designates the end of the stack. I'll just break out then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19655#discussion_r1651995435


More information about the hotspot-dev mailing list