RFR: 8319947: Recursive lightweight locking: s390x implementation [v6]

[Amit Kumar]

On Tue, 25 Jun 2024 09:55:21 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge branch 'master' into recursive_locking_v1
>>  - not using load_const_optimized in compiler_fast_lock_lightweight_object
>>  - minor code formatting & variable renamings
>>  - revert DiagnoseSyncOnValueBasedClasses changes from c1
>>  - suggestions from Axel
>>  - Merge branch 'master' into recursive_locking_v1
>>  - s390x recursive locking port
>
> src/hotspot/cpu/s390/s390.ad line 9614:
> 
>> 9612:     // If unlocking was successful, cc should indicate 'EQ'.
>> 9613:     // The compiler generates a branch to the runtime call to
>> 9614:     // _complete_monitor_unlocking_Java for the case where cc is 'NE'.
> 
> Shouldn't the comment talk about locking here?

Yes it should!!! Please take a look at latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18878#discussion_r1652552902