RFR: 8331126: [s390x] secondary_super_cache does not scale well [v4]

Amit Kumar amitkumar at openjdk.org
Tue Jun 25 13:07:40 UTC 2024


On Mon, 24 Jun 2024 14:12:05 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/cpu/s390/macroAssembler_s390.cpp
>>  - rename: r_scratch to r_result in repne_scan method
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3325:
> 
>> 3323:   assert(Klass::SECONDARY_SUPERS_BITMAP_FULL == ~uintx(0), "");
>> 3324: 
>> 3325:   z_cghi(r_bitmap, (long)-1);
> 
> Why not compare against `(unitx)Klass::SECONDARY_SUPERS_BITMAP_FULL`?

Updated, Please see the latest commit. Tier1 test are still fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19544#discussion_r1652788045


More information about the hotspot-dev mailing list