RFR: 8331126: [s390x] secondary_super_cache does not scale well [v6]

[Amit Kumar]

On Wed, 26 Jun 2024 19:49:29 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add2reg -> z_la
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3452:
> 
>> 3450:   z_lgr(Z_ARG4, r_result);
>> 3451:   const char* msg = "mismatch";
>> 3452:   load_const_optimized(Z_ARG5, (address)msg);
> 
> Did you test this? It breaks when you have a register collision (see my assert_different_registers on PPC64). You can test it by removing the `z_bre` above and checking if the arguments are correct.

I found one log, from when I was implementing this: 

fatal error: mismatch: java.lang.Integer implements java.util.concurrent.Callable: is_subtype_of: 0; linear_search: 0; table_lookup: 1

Context: repne_scan wasn't working properly, table_lookup came up to "1" and repne_scan returned "0" so check failed.

 For surety let me just add the asserts as well and see what happens.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19544#discussion_r1655981907