RFR: 8335108: Build error after JDK-8333658 due to class templates

[Kim Barrett]

On Tue, 25 Jun 2024 18:52:20 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

> Hi all, 
> 
> This PR addresses [8335108](https://bugs.openjdk.org/browse/JDK-8335108). 
> 
> The error arises as template-id is not allowed for constructor/destructor in C++20. 
> 
> Testing: 
> - [x] Compilation succeeds with g++ 14.1.1.
> 
> Thanks, 
> Sonia

Coming late to the party, since y'all forgot the 24 hour rule for integrating
changes, unless there is mutual agreement that it's a trivial change.

Change looks good, and indeed I'd have agreed with a suggestion that it's
trivial. I think fixing this kind of thing is worthwhile since the template
parameters add nothing and just promote confusion. (Which is likely why the
later standard removed them.)  We might use C++20 someday, but I'm guessing
not soon; there are a fair number of changes that impact us.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19890#issuecomment-2193625497