RFR: 8335108: Build error after JDK-8333658 due to class templates

Julian Waters jwaters at openjdk.org
Thu Jun 27 05:29:17 UTC 2024


On Tue, 25 Jun 2024 18:52:20 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

> Hi all, 
> 
> This PR addresses [8335108](https://bugs.openjdk.org/browse/JDK-8335108). 
> 
> The error arises as template-id is not allowed for constructor/destructor in C++20. 
> 
> Testing: 
> - [x] Compilation succeeds with g++ 14.1.1.
> 
> Thanks, 
> Sonia

I guess you learn something new every day, since this is the first time I'm hearing about the 24 hour rule (I always thought the only HotSpot requirement was 2 Reviewers, besides needing a 2 week waiting periods for Style Guide changes, never knew you had to wait 24 hours for regular ones too). It's a good thing this change was trivial in the end

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19890#issuecomment-2193751661


More information about the hotspot-dev mailing list