RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v2]

Martin Doerr mdoerr at openjdk.org
Thu Jun 27 08:37:13 UTC 2024


On Wed, 26 Jun 2024 16:56:40 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   empty lines
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 349:
> 
>> 347: // Set register dst to true if dst is non zero using temp for calculations on Power Version<10.
>> 348: // Set register dst to true if dst is non zero for Power 10 and above machines.
>> 349: void MacroAssembler::normalize_bool(Register dst, Register temp, bool use_64bit) {
> 
> I would've used `is_64bit/is_long` instead of `use_64bit`. But that's personal choice and leave it upto you.

`is_64bit` would be fine with me, too. As you prefer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19886#discussion_r1656693812


More information about the hotspot-dev mailing list