RFR: 8335108: Build error after JDK-8333658 due to class templates

[Sonia Zaldana Calles]

On Thu, 27 Jun 2024 05:54:43 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> I guess you learn something new every day, since this is the first time I'm hearing about the 24 hour rule (I always thought the only HotSpot requirement was 2 Reviewers, besides needing a 2 week waiting periods for Style Guide changes, never knew you had to wait 24 hours for regular ones too). It's a good thing this change was trivial in the end
>
>> I guess you learn something new every day, since this is the first time I'm hearing about the 24 hour rule (I always thought the only HotSpot requirement was 2 Reviewers, besides needing a 2 week waiting periods for Style Guide changes, never knew you had to wait 24 hours for regular ones too). It's a good thing this change was trivial in the end
> 
> It's a JDK rule, not specific to HotSpot.  
> https://openjdk.org/guide/
> Life of a PR
> 6. Allow enough time for review
> 
> https://github.com/openjdk/guide/blame/95f1cd24c657c7837c359c7ba1a80e15319bcd15/src/guide/working-with-pull-requests.md#L77-L80
> 
> I don't remember where that requirement originally came from, before being incorporated into the guide.  I thought
> there was someplace old but public that prescribed 1 Reviewer and 24 hours, but can't find it right now.  Maybe it was in the openjdk.org contributing or sponsoring pages and got cleaned up when added to the guide?

@kimbarrett Understood, thanks for bringing that to my attention. Luckily the change was trivial this time but I will note that for the future.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19890#issuecomment-2194834971