RFR: 8331126: [s390x] secondary_super_cache does not scale well [v6]
Amit Kumar
amitkumar at openjdk.org
Thu Jun 27 18:07:18 UTC 2024
On Thu, 27 Jun 2024 16:02:04 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> I guess this check requires the r_result to be in range `[0,1]`. So it checks (without modifying) whether the value is greater than or equal to 0 & less than equal to 1.
>>
>> By "clear bit 0" did you mean to `and` it with `1` and then do the check ? I'm really not sure what were your thoughts. Could you please elaborate ?
>
> There are several ways to clear the least significant bit. E.g. `and` it with ~1 and compare the result with 0. Or shift right by 1 and compare the result with 0.
But if we clobber this then verification will fail. Because in this method we are dependent on value present in `r_result`. It's just that I'm making sure that whatever value is there it's either `1` or `0`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19544#discussion_r1657574235
More information about the hotspot-dev
mailing list