RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v6]

[Martin Doerr]

On Thu, 27 Jun 2024 17:34:11 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> [JDK-8331732](https://bugs.openjdk.org/browse/JDK-8331732)
>> The template interpreter contains branch-free conversion code for T_BOOLEAN (TemplateInterpreterGenerator::generate_result_handler_for).
>> 
>> SharedRuntime::generate_native_wrapper uses unoptimized code to "Unpack the native result" for T_BOOLEAN.
>> Power10 has the "setbc" / "setbcr" instruction.
>> 
>> A new function has been created for the conversion and use "setbcr" on Power10 (determined by VM_Version::has_brw()) and otherwise the branch-free implementation. We should have a function for 32 and one for 64 bit operations (or one with supports both).
>> 
>> The new code for MacroAssembler::verify_secondary_supers_table  also uses the new function.
>
> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  -  remove assembler header
>  -  remove assembler header

src/hotspot/cpu/ppc/assembler_ppc.inline.hpp line 426:

> 424: inline void Assembler::setbcr(Register d, ConditionRegister cr, Condition cc) {
> 425:    setbcr(d, bi0(cr, cc));
> 426:  }

Please adapt indentation. It's a bit off. (See previous code.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19886#discussion_r1658476978