RFR: 8331126: [s390x] secondary_super_cache does not scale well [v8]

[Martin Doerr]

On Fri, 28 Jun 2024 09:36:41 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Should I change it ?
>
> What does "in future" mean? In the next couple of nanoseconds after this instruction executes? When someone changes this code?
> You need to say, precisely, what this routine provides. That is to say, what is its postcondition. If some logic is not necessary for that postcondition, don't do it.
> This routine sets result, or it sets flags, or both. Say which of these it is, the make sure that all code paths do so.

I think the `z_cghi` is only used for the `asm_assert`. I'd guard both with `ifdef ASSERT`. Or combine it with the assert block below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19544#discussion_r1658720301