RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v17]

Suchismith Roy sroy at openjdk.org
Fri Jun 28 20:26:18 UTC 2024


On Fri, 28 Jun 2024 18:07:02 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2386:
>> 
>>> 2384: 
>>> 2385:   // convert !=0 to 1
>>> 2386:   normalize_bool(result, true);
>> 
>> wait, is build successful with this code change ?
>
> I think you can't specify the parameters arbitrarily like this. If you want to pass "true" then you have to specify the register as well;

Build is succeding . And i also did a register check for templateGenerator with this example using normalize_bool(result,false) ,(java -version was not hitting this code). Seems to be working fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19886#discussion_r1659283834


More information about the hotspot-dev mailing list