RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v17]

[Amit Kumar]

On Fri, 28 Jun 2024 17:50:48 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> [JDK-8331732](https://bugs.openjdk.org/browse/JDK-8331732)
>> The template interpreter contains branch-free conversion code for T_BOOLEAN (TemplateInterpreterGenerator::generate_result_handler_for).
>> 
>> SharedRuntime::generate_native_wrapper uses unoptimized code to "Unpack the native result" for T_BOOLEAN.
>> Power10 has the "setbc" / "setbcr" instruction.
>> 
>> A new function has been created for the conversion and use "setbcr" on Power10 (determined by VM_Version::has_brw()) and otherwise the branch-free implementation. We should have a function for 32 and one for 64 bit operations (or one with supports both).
>> 
>> The new code for MacroAssembler::verify_secondary_supers_table  also uses the new function.
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   default value usage

src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp line 279:

> 277:     setbcr(dst, CCR0, Assembler::equal);
> 278:   } else {
> 279:     neg(temp, dst);

I guess it would be better if we add assert here, `assert_different_registers(dst, temp);`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19886#discussion_r1659498940