RFR: 8331126: [s390x] secondary_super_cache does not scale well [v4]
Amit Kumar
amitkumar at openjdk.org
Sat Jun 29 12:29:20 UTC 2024
On Wed, 26 Jun 2024 19:36:46 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3275:
>>
>>> 3273: call_stub(StubRoutines::lookup_secondary_supers_table_slow_path_stub());
>>> 3274:
>>> 3275: z_bru(L_done); // pass whatever result we got from a slow path
>>
>> This one branch could be saved by using "load immediate on condition". But it's after slow path processing.
>
> Right, looks like we only reach here with "false" condition or after return from the stub which should have set the condition code accordingly, too (should be checked / enforced!).
I have opened [JDK-8335367](https://bugs.openjdk.org/browse/JDK-8335367) which will take care of this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19544#discussion_r1659805508
More information about the hotspot-dev
mailing list