RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v18]
Martin Doerr
mdoerr at openjdk.org
Sat Jun 29 13:08:25 UTC 2024
On Sat, 29 Jun 2024 06:47:52 GMT, Suchismith Roy <sroy at openjdk.org> wrote:
>> [JDK-8331732](https://bugs.openjdk.org/browse/JDK-8331732)
>> The template interpreter contains branch-free conversion code for T_BOOLEAN (TemplateInterpreterGenerator::generate_result_handler_for).
>>
>> SharedRuntime::generate_native_wrapper uses unoptimized code to "Unpack the native result" for T_BOOLEAN.
>> Power10 has the "setbc" / "setbcr" instruction.
>>
>> A new function has been created for the conversion and use "setbcr" on Power10 (determined by VM_Version::has_brw()) and otherwise the branch-free implementation. We should have a function for 32 and one for 64 bit operations (or one with supports both).
>>
>> The new code for MacroAssembler::verify_secondary_supers_table also uses the new function.
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>
> default value correction
I don't require more changes. I've run a couple of tests on Power9 and Power10. Also with -XX:+VerifySecondarySupers to test the new code. Results are good.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19886#pullrequestreview-2149603162
More information about the hotspot-dev
mailing list