RFR: 8327058: RISC-V: make Zcb experimental

Fei Yang fyang at openjdk.org
Fri Mar 1 02:45:56 UTC 2024


On Thu, 29 Feb 2024 17:31:52 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you review the patch to add a flag for Zcb extension to enable user to control it?
> Thanks.
> 
> As discussed in [1], it's good to give a flag to control Zcb, and currently it's good to make it experimental.
> 
> [1] https://github.com/openjdk/jdk/pull/17698#discussion_r1505364098

Thanks.

src/hotspot/cpu/riscv/globals_riscv.hpp line 108:

> 106:   product(bool, UseZbb, false, "Use Zbb instructions")                           \
> 107:   product(bool, UseZbs, false, "Use Zbs instructions")                           \
> 108:   product(bool, UseZcb, false, EXPERIMENTAL, "Use Zcb instructions")             \

Nit: Can you move this after the line for `UseZfh`. I would like to group EXPERIMENTAL options together.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18070#pullrequestreview-1910221663
PR Review Comment: https://git.openjdk.org/jdk/pull/18070#discussion_r1508416995


More information about the hotspot-dev mailing list