RFR: 8327049: Stop exporting debug.cpp functions on gcc [v2]

Magnus Ihse Bursie ihse at openjdk.org
Fri Mar 1 13:42:51 UTC 2024


On Thu, 29 Feb 2024 21:18:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I had expected to see an actual reversion to the undef of JNIEXPORT but this will do albeit more extensive a change.

To me, `#undef` is really the worst kind of hack that should be used only when you do not have full control over the source code where it is defined. Arbitrarily removal of macro definitions makes it much harder to reason about the source code.

It was put in place just to get ahead of the mapfile removal with minimal changes, and the intention to remove it as soon as possible.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18062#issuecomment-1973224766


More information about the hotspot-dev mailing list