RFR: 8256314: JVM TI GetCurrentContendedMonitor is implemented incorrectly [v4]
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Mar 5 04:17:59 UTC 2024
On Mon, 4 Mar 2024 09:49:07 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> src/java.se/share/data/jdwp/jdwp.spec line 1985:
>>
>>> 1983: "thread may be waiting to enter the object's monitor, or in "
>>> 1984: "java.lang.Object.wait waiting to re-enter the monitor after being "
>>> 1985: "notified, interrupted, or timeout."
>>
>> `timed-out` would be the correct sense here.
>
> Thank you, David. I was thinking about it but was not sure. Will update it.
Fixed now. Also, updated CSR and RN.
>> src/jdk.jdi/share/classes/com/sun/jdi/ThreadReference.java line 314:
>>
>>> 312: * synchronized method, the synchronized statement, or
>>> 313: * {@link Object#wait} waiting to re-enter the monitor
>>> 314: * after being notified, interrupted, or timeout.
>>
>> Again `timed-out`.
>
> Will fix, thanks.
Fixed now. Also, updated CSR and RN.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17944#discussion_r1512112147
PR Review Comment: https://git.openjdk.org/jdk/pull/17944#discussion_r1512112210
More information about the hotspot-dev
mailing list