RFR: 8256314: JVM TI GetCurrentContendedMonitor is implemented incorrectly [v6]

[Serguei Spitsyn]

On Tue, 5 Mar 2024 18:39:43 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: added new internal function JvmtiEnvBase::get_thread_or_vthread_state
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/waitingThreads/waitingthreads004a.java line 106:
> 
>> 104:                 display("entered and notifyAll: synchronized (lockingObject) {}");
>> 105:                 lockingObject.notifyAll();
>> 106: 
> 
> Please update test documentation in TestDescription. line:
>      - An object with threads waiting in Object.wait(long) method.
>  should be updated/or another one added.

Thanks, updated `TestDescription.java` now.

> test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/CurrentContendedMonitor/curcontmonitor001a.java line 88:
> 
>> 86:             // ensure that tested thread is waiting for monitor object
>> 87:             synchronized (TestedClass.thread.monitor) {
>> 88:                 TestedClass.thread.monitor.notifyAll();
> 
> You need to update test documentation in TestDescription.java to explicitly say that test not "waiting" but exit from wait and waiting for monitor (contended).

Thanks, updated `TestDescription.java` now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17944#discussion_r1513663234
PR Review Comment: https://git.openjdk.org/jdk/pull/17944#discussion_r1513663121