RFR: JDK-8324682 Remove redefinition of NULL for XLC compiler [v5]

[Christoph Langer]

On Thu, 7 Mar 2024 08:13:52 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> Remove redefinition of NULL for XLC compiler
>> In globalDefinitions_xlc.hpp there is a redefinition of NULL to work around an issue with one of the AIX headers (<dirent.h>). 
>> Once all uses of NULL in HotSpot have been replaced with nullptr, there is no longer any need for this, and it can be removed.
>> 
>> 
>> JBS ISSUE : [JDK-8324682](https://bugs.openjdk.org/browse/JDK-8324682)
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update comment and copyright

Changes requested by clanger (Reviewer).

src/hotspot/share/utilities/globalDefinitions_xlc.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 1998, 2023, Oracle and/or its affiliates. All rights reserved.

You need to update the year for the Oracle copyright. Adding additional copyright lines, such as IBM, is usually only done when you substantially change a file, i.e. add larger non-trivial portions of code.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18064#pullrequestreview-1922127498
PR Review Comment: https://git.openjdk.org/jdk/pull/18064#discussion_r1515961111