RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v8]

[Boris Ulasevich]

On Tue, 20 Feb 2024 23:12:01 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   one another cleanup round
>
> src/hotspot/share/code/codeCache.cpp line 197:
> 
>> 195: };
>> 196: 
>> 197: static void set_size_of_unset_code_heap(CodeHeapInfo* heap, size_t available_size, size_t known_segments_size, size_t min_size) {
> 
> Suggest renaming: `known_segments_size` -> `used_size`.

ok. thanks

> src/hotspot/share/code/codeCache.cpp line 227:
> 
>> 225:   if (!heap_available(CodeBlobType::MethodNonProfiled)) {
>> 226:     assert(false, "MethodNonProfiled heap is always available for segmented code heap");
>> 227:   }
> 
> It's just:
> 
> assert(heap_available(CodeBlobType::MethodNonProfiled), "MethodNonProfiled heap must be always available for segmented code heap");

yes

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1515992672
PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1515993528