RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v7]

[Boris Ulasevich]

On Mon, 19 Feb 2024 20:20:55 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor update. removed helper function as it caused many comments in the review
>
> src/hotspot/share/code/codeCache.cpp line 243:
> 
>> 241:   if (!profiled.set && !non_profiled.set) {
>> 242:     non_profiled.size = profiled.size = (cache_size > non_nmethod.size + 2 * min_size) ?
>> 243:                                         (cache_size - non_nmethod.size) / 2 : min_size;
> 
> I prefer to show explicitly with `else if` that it is an alternative case. This prevents from inserting any code between these two IFs.

I see. I want to have minimal dependencies in between subsequent lines. Let me keep my variant. Thanks,

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1516007432