RFR: JDK-8324682 Remove redefinition of NULL for XLC compiler [v5]

Suchismith Roy sroy at openjdk.org
Fri Mar 8 09:07:23 UTC 2024


On Thu, 7 Mar 2024 10:57:25 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update comment and copyright
>
> src/hotspot/share/utilities/globalDefinitions_xlc.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 1998, 2023, Oracle and/or its affiliates. All rights reserved.
> 
> You need to update the year for the Oracle copyright. Adding additional copyright lines, such as IBM, is usually only done when you substantially change a file, i.e. add larger non-trivial portions of code.

Ok. Thanks will keep that in mind. Updated the copyrights year.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18064#discussion_r1517436048


More information about the hotspot-dev mailing list