RFR: JDK-8324682 Remove redefinition of NULL for XLC compiler [v6]

Kim Barrett kbarrett at openjdk.org
Tue Mar 12 17:22:20 UTC 2024


On Fri, 8 Mar 2024 09:07:23 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> Remove redefinition of NULL for XLC compiler
>> In globalDefinitions_xlc.hpp there is a redefinition of NULL to work around an issue with one of the AIX headers (<dirent.h>). 
>> Once all uses of NULL in HotSpot have been replaced with nullptr, there is no longer any need for this, and it can be removed.
>> 
>> 
>> JBS ISSUE : [JDK-8324682](https://bugs.openjdk.org/browse/JDK-8324682)
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>    update copyright

> /integrate

For HotSpot changes, at least 2 reviewers (at least one a Reviewer) are required.  The Skara tooling doesn't know about
that policy for HotSpot (and some other areas that have similar policies), so will mark a PR ready even though that
requirement hasn't been satisfied.  Sometimes someone will use the /reviewers command to enforce the policy, but
since it's a "well known" policy that often isn't bothered with.

That said, since I've now also approved it, I will also sponsor.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18064#issuecomment-1992172210


More information about the hotspot-dev mailing list