RFR: 8328081: Remove unnecessary return statement in method `markWord::displaced_mark_helper` [v2]

David Holmes dholmes at openjdk.org
Wed Mar 13 22:02:40 UTC 2024


On Wed, 13 Mar 2024 13:39:46 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This trivial patch removes unnecessary return statement in method `markWord::displaced_mark_helper`.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into REMOVE_UNNECESSARY_CODE
>  - Remove unnecessary code.

You would need to verify that this does not cause a build warning with all supported compilers on all platforms. As stated above these "fake" returns exist precisely because compilers (in the past at least) did not recognize that `fatal` is non-returning.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18272#issuecomment-1995947093


More information about the hotspot-dev mailing list