RFR: 8328081: Remove unnecessary return statement in method `markWord::displaced_mark_helper` [v2]
Guoxiong Li
gli at openjdk.org
Thu Mar 14 06:28:41 UTC 2024
On Thu, 14 Mar 2024 05:33:41 GMT, David Holmes <dholmes at openjdk.org> wrote:
> My point was a bit too subtle. Given that you can't verify all the compilers as needed, the change should not be made in my opinion.
Got it. Thanks for your kindly discussion and suggestion.
> The method `markWord::set_displaced_mark_helper` has no return statement at the end. So I want the `markWord::displaced_mark_helper` to be consistent with `markWord::set_displaced_mark_helper`.
I notice the return value of the method `markWord::set_displaced_mark_helper` is `void`, but the method `markWord::displaced_mark_helper` has a not empty return value. It is the point I missed so that I submitted this wrong PR.
It is my negligence. Apologize for wasting your time.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18272#issuecomment-1996611599
More information about the hotspot-dev
mailing list