RFR: 8327652: S390x: Implements SLP support [v2]

Sidraya Jayagond sjayagond at openjdk.org
Fri Mar 15 12:15:44 UTC 2024


On Fri, 8 Mar 2024 05:41:25 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> src/hotspot/share/adlc/output_c.cpp line 2366:
> 
>> 2364:     if (strcmp(rep_var,"$VectorSRegister") == 0)  return "as_VectorSRegister";
>> 2365: #endif
>> 2366: #if defined(S390)
> 
> can't we use `#elif` here ?

Could be changed. I would keep it as is for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1526199731


More information about the hotspot-dev mailing list