RFR: 8327652: S390x: Implements SLP support [v3]

Sidraya Jayagond sjayagond at openjdk.org
Tue Mar 19 02:59:20 UTC 2024


On Mon, 18 Mar 2024 12:48:37 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add proper comments and cosmetic changes.
>
> src/hotspot/cpu/s390/s390.ad line 192:
> 
>> 190: // ----------------------------
>> 191:   // 1st 16 VRs are aliases for the FPRs which are already defined above.
>> 192:   reg_def Z_VR0   ( SOC, SOC, Op_RegF, 0, VMRegImpl::Bad());
> 
> I think `Op_VecX` should be used. The _H, _J, _K versions shouldn't be needed.

Thanks, Working on this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1529618542


More information about the hotspot-dev mailing list