RFR: 8327652: S390x: Implements SLP support [v4]

Sidraya Jayagond sjayagond at openjdk.org
Wed Mar 20 09:13:21 UTC 2024


On Tue, 19 Mar 2024 15:15:39 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Op_VecX instead of Op_RegF
>>   
>>   Signed-off-by: Sidraya <sidraya.jayagond at ibm.com>
>
> src/hotspot/cpu/s390/sharedRuntime_s390.cpp line 487:
> 
>> 485: void RegisterSaver::restore_live_registers(MacroAssembler* masm, RegisterSet reg_set, bool save_vectors) {
>> 486:   int offset;
>> 487:   //const int register_save_offset = live_reg_frame_size(reg_set) - live_reg_save_size(reg_set);
> 
> Do we need to keep this commented code?

No, I delete it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1531721478


More information about the hotspot-dev mailing list