RFR: 8327652: S390x: Implements SLP support [v4]

Martin Doerr mdoerr at openjdk.org
Wed Mar 20 09:40:22 UTC 2024


On Wed, 20 Mar 2024 09:25:12 GMT, Sidraya Jayagond <sjayagond at openjdk.org> wrote:

>> src/hotspot/cpu/s390/s390.ad line 7473:
>> 
>>> 7471: // Sqrt float precision
>>> 7472: instruct sqrtF_reg(regF dst, regF src) %{
>>> 7473:   match(Set dst (SqrtF src));
>> 
>> Did the old code cause problems? Required nodes not matched? Maybe this should get fixed in a separate PR for backports?
>
> [JDK-8308277](https://bugs.openjdk.org/browse/JDK-8308277)  This one was done for RISCV platform. If I do not make this change vectorization for float squreroot (Match.sqrt()) does not happen on s390x.  Unlike RISCV I did not see ConvF2D -> ConvD2F IR Node sequence on s390x.
> Shall I raise a separate PR for this. ?

I think doing this in a separate PR makes sense. You may want to backport it to 21 and/or 17.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1531759589


More information about the hotspot-dev mailing list