RFR: 8325536: JVM crash during CDS archive creation with -XX:+AllowArchivingWithJavaAgent

[Calvin Cheung]

The bug only reproduces with dynamic dump.
A fix is to call `assign_class_loader_type()` in `KlassFactory::check_shared_class_file_load_hook()` instead of in `ArchiveBuilder::make_klasses_shareable()`.

Passed tiers 1 - 4 testing.

-------------

Commit messages:
 - call assign_class_loader_type() in KlassFactory
 - Revert "factor out assigning of class loader type out of make_klasses_shareable"
 - factor out assigning of class loader type out of make_klasses_shareable
 - 8325536: JVM crash during CDS archive creation with -XX:+AllowArchivingWithJavaAgent

Changes: https://git.openjdk.org/jdk/pull/18254/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18254&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8325536
  Stats: 68 lines in 5 files changed: 60 ins; 4 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18254.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18254/head:pull/18254

PR: https://git.openjdk.org/jdk/pull/18254