RFR: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp [v3]

David Holmes dholmes at openjdk.org
Fri Mar 22 03:26:21 UTC 2024


On Thu, 21 Mar 2024 19:26:33 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This small PR is an attempt at improving the comment in the UNSAFE_ENTRY_SCOPED macro.
>> I found that the comment contained some duplicated claims, did not properly introduced the concepts it referred to, and some of its claims were not explained in full.
>> 
>> As this is a delicate part of how FFM ensures the "no use after free" guarantee, I think it would be a good idea for this comment to better reflect what the expectations are.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

That all reads fine to me too.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18429#pullrequestreview-1953872252


More information about the hotspot-dev mailing list